LaconicNetwork/cosmos-sdk
7
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 2 Wiki Activity

ci: improve error checking (errcheck linter) (#11195)

Browse Source 
## Description

Implements part of #7258

Check some of currently unchecked errors.

- [x] baseapp
- [x] client
- [x] codec
- [x] crypto
- [x] server
- [x] simapp
- [ ] snapshots
- [ ] store
- [x] testutil
- [ ] types
- [ ] modules

---

### Author Checklist

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

- [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] added `!` to the type prefix if API or client breaking change
- [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting))
- [ ] provided a link to the relevant issue or specification
- [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules)
- [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing)
- [ ] added a changelog entry to `CHANGELOG.md`
- [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [ ] updated the relevant documentation or specification
- [ ] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed 
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)
This commit is contained in:
Julien Robert
2022-04-13 06:46:51 +00:00
committed by GitHub
parent fed09c593a
commit 1fe59eb22a
39 changed files with 240 additions and 162 deletions
Download Patch File Download Diff File Expand all files Collapse all files
client/tx/aux_builder_test.go
+25 -29
View File
@@ -60,7 +60,7 @@ func TestAuxTxBuilder(t *testing.T) {
{
"GetSignBytes pubkey should not be nil",
func() error {
b.SetMsgs(msg1)
require.NoError(t, b.SetMsgs(msg1))
_, err := b.GetSignBytes()
return err
@@ -70,8 +70,8 @@ func TestAuxTxBuilder(t *testing.T) {
{
"GetSignBytes invalid sign mode",
func() error {
b.SetMsgs(msg1)
b.SetPubKey(pub1)
require.NoError(t, b.SetMsgs(msg1))
require.NoError(t, b.SetPubKey(pub1))
_, err := b.GetSignBytes()
return err
@@ -81,13 +81,12 @@ func TestAuxTxBuilder(t *testing.T) {
{
"GetSignBytes tipper should not be nil (if tip is set)",
func() error {
b.SetMsgs(msg1)
b.SetPubKey(pub1)
require.NoError(t, b.SetMsgs(msg1))
require.NoError(t, b.SetPubKey(pub1))
b.SetTip(&typestx.Tip{})
err := b.SetSignMode(signing.SignMode_SIGN_MODE_DIRECT_AUX)
require.NoError(t, err)
require.NoError(t, b.SetSignMode(signing.SignMode_SIGN_MODE_DIRECT_AUX))
_, err = b.GetSignBytes()
_, err := b.GetSignBytes()
return err
},
true, "tipper cannot be empty",
@@ -95,13 +94,12 @@ func TestAuxTxBuilder(t *testing.T) {
{
"GetSignBytes works for DIRECT_AUX",
func() error {
b.SetMsgs(msg1)
b.SetPubKey(pub1)
require.NoError(t, b.SetMsgs(msg1))
require.NoError(t, b.SetPubKey(pub1))
b.SetTip(tip)
err := b.SetSignMode(signing.SignMode_SIGN_MODE_DIRECT_AUX)
require.NoError(t, err)
require.NoError(t, b.SetSignMode(signing.SignMode_SIGN_MODE_DIRECT_AUX))
_, err = b.GetSignBytes()
_, err := b.GetSignBytes()
return err
},
false, "",
@@ -109,13 +107,12 @@ func TestAuxTxBuilder(t *testing.T) {
{
"GetAuxSignerData address should not be empty",
func() error {
b.SetMsgs(msg1)
b.SetPubKey(pub1)
require.NoError(t, b.SetMsgs(msg1))
require.NoError(t, b.SetPubKey(pub1))
b.SetTip(tip)
err := b.SetSignMode(signing.SignMode_SIGN_MODE_DIRECT_AUX)
require.NoError(t, err)
require.NoError(t, b.SetSignMode(signing.SignMode_SIGN_MODE_DIRECT_AUX))
_, err = b.GetSignBytes()
_, err := b.GetSignBytes()
require.NoError(t, err)
_, err = b.GetAuxSignerData()
@@ -126,14 +123,13 @@ func TestAuxTxBuilder(t *testing.T) {
{
"GetAuxSignerData signature should not be empty",
func() error {
b.SetMsgs(msg1)
b.SetPubKey(pub1)
require.NoError(t, b.SetMsgs(msg1))
require.NoError(t, b.SetPubKey(pub1))
b.SetTip(tip)
b.SetAddress(addr1.String())
err := b.SetSignMode(signing.SignMode_SIGN_MODE_DIRECT_AUX)
require.NoError(t, err)
require.NoError(t, b.SetSignMode(signing.SignMode_SIGN_MODE_DIRECT_AUX))
_, err = b.GetSignBytes()
_, err := b.GetSignBytes()
require.NoError(t, err)
_, err = b.GetAuxSignerData()
@@ -149,8 +145,8 @@ func TestAuxTxBuilder(t *testing.T) {
b.SetTimeoutHeight(timeoutHeight)
b.SetMemo(memo)
b.SetChainID(chainID)
b.SetMsgs(msg1)
b.SetPubKey(pub1)
require.NoError(t, b.SetMsgs(msg1))
require.NoError(t, b.SetPubKey(pub1))
b.SetTip(tip)
b.SetAddress(addr1.String())
err := b.SetSignMode(signing.SignMode_SIGN_MODE_DIRECT_AUX)
@@ -172,8 +168,8 @@ func TestAuxTxBuilder(t *testing.T) {
{
"GetSignBytes works for LEGACY_AMINO_JSON",
func() error {
b.SetMsgs(msg1)
b.SetPubKey(pub1)
require.NoError(t, b.SetMsgs(msg1))
require.NoError(t, b.SetPubKey(pub1))
b.SetTip(tip)
b.SetAddress(addr1.String())
err := b.SetSignMode(signing.SignMode_SIGN_MODE_LEGACY_AMINO_JSON)
@@ -192,8 +188,8 @@ func TestAuxTxBuilder(t *testing.T) {
b.SetTimeoutHeight(timeoutHeight)
b.SetMemo(memo)
b.SetChainID(chainID)
b.SetMsgs(msg1)
b.SetPubKey(pub1)
require.NoError(t, b.SetMsgs(msg1))
require.NoError(t, b.SetPubKey(pub1))
b.SetTip(tip)
b.SetAddress(addr1.String())
err := b.SetSignMode(signing.SignMode_SIGN_MODE_LEGACY_AMINO_JSON)