From 1dcf6330840a38d9dae91ed45b88cf7e35e3fc4d Mon Sep 17 00:00:00 2001 From: Aleksandr Bezobchuk Date: Tue, 5 Jul 2022 17:12:38 -0400 Subject: [PATCH] chore: fix x/mint param sims (#12461) `RandomizedParams` generates random parameter changes during simulations, however, it does so through `ParamChangeProposal` which is now legacy. Once all modules are migrated we will remove `RandomizedParams` entirely from the simulation interface. For now, we just return an empty slice. --- .github/workflows/test.yml | 1 - x/mint/module.go | 6 +++++- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 66c9111e3c..2c0b448770 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -291,7 +291,6 @@ jobs: **/**.go go.mod go.sum - if: env.GIT_DIFF - name: test-sim-nondeterminism run: | make test-sim-nondeterminism diff --git a/x/mint/module.go b/x/mint/module.go index c802a16309..c4df3df779 100644 --- a/x/mint/module.go +++ b/x/mint/module.go @@ -207,8 +207,12 @@ func (AppModule) ProposalContents(simState module.SimulationState) []simtypes.We } // RandomizedParams creates randomized mint param changes for the simulator. +// +// TODO: Returns an empty slice which will make parameter changes a no-op during +// simulations. Once all modules are migrated, remove RandomizedParams from +// the simulation interface. func (AppModule) RandomizedParams(r *rand.Rand) []simtypes.ParamChange { - return simulation.ParamChanges(r) + return []simtypes.ParamChange{} } // RegisterStoreDecoder registers a decoder for mint module's types.