LaconicNetwork/cosmos-sdk
9
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 2 Wiki Activity

chore(client): use command's configured output (#22334)

Browse Source
This commit is contained in:
Mark Rushakoff 2024-10-22 19:08:45 -04:00 committed by GitHub
parent cd3ce0c7a4
commit 1c949f772f
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 27 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
client/cmd.go
View File

@ -345,7 +345,7 @@ func GetClientQueryContext(cmd *cobra.Command) (Context, error) {
// - client.Context field pre-populated & flag not set: uses pre-populated value
// - client.Context field pre-populated & flag set: uses set flag value
func GetClientTxContext(cmd *cobra.Command) (Context, error) {
ctx := GetClientContextFromCmd(cmd)
ctx := GetClientContextFromCmd(cmd).WithOutput(cmd.OutOrStdout())
return readTxCommandFlags(ctx, cmd.Flags())
}

26
client/cmd_test.go
View File

@ -1,6 +1,7 @@
package client_test
import (
"bytes"
"context"
"fmt"
"testing"
@ -137,3 +138,28 @@ func TestSetCmdClientContextHandler(t *testing.T) {
})
}
}
func TestContext_usesCobraCommandOutput(t *testing.T) {
var initCtx client.Context
cmd := &cobra.Command{
PreRunE: func(cmd *cobra.Command, args []string) error {
return client.SetCmdClientContextHandler(initCtx, cmd)
},
RunE: func(cmd *cobra.Command, _ []string) error {
cctx, err := client.GetClientTxContext(cmd)
if err != nil {
return err
}
return cctx.PrintString("hello")
},
}
var outBuf bytes.Buffer
cmd.SetOutput(&outBuf)
require.NoError(t, cmd.Execute())
require.Equal(t, "hello", outBuf.String())
}