From 17c84ab34a36a79b7690c3342e3463ebcaf33ad3 Mon Sep 17 00:00:00 2001 From: Alexander Bezobchuk Date: Wed, 6 Feb 2019 14:20:36 -0800 Subject: [PATCH] Merge PR #3524: fix keys add flow to show seed by default --- PENDING.md | 4 +++- client/keys/add.go | 5 +++-- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/PENDING.md b/PENDING.md index de670bea23..792566690d 100644 --- a/PENDING.md +++ b/PENDING.md @@ -71,7 +71,9 @@ IMPROVEMENTS * Gaia CLI (`gaiacli`) * [\#3476](https://github.com/cosmos/cosmos-sdk/issues/3476) New `withdraw-all-rewards` command to withdraw all delegations rewards for delegators. - - [\#3497](https://github.com/cosmos/cosmos-sdk/issues/3497) `gaiad gentx` supports `--ip` and `--node-id` flags to override defaults. + * [\#3497](https://github.com/cosmos/cosmos-sdk/issues/3497) `gaiad gentx` supports `--ip` and `--node-id` flags to override defaults. + * [\#3518](https://github.com/cosmos/cosmos-sdk/issues/3518) Fix flow in + `keys add` to show the mnemonic by default. * Gaia * [\#3418](https://github.com/cosmos/cosmos-sdk/issues/3418) Add vesting account diff --git a/client/keys/add.go b/client/keys/add.go index a7c8c6b52f..856f79f3be 100644 --- a/client/keys/add.go +++ b/client/keys/add.go @@ -14,12 +14,13 @@ import ( "github.com/cosmos/cosmos-sdk/crypto/keys" sdk "github.com/cosmos/cosmos-sdk/types" - "github.com/cosmos/go-bip39" "github.com/gorilla/mux" "github.com/pkg/errors" "github.com/spf13/cobra" "github.com/spf13/viper" + "github.com/cosmos/go-bip39" + "github.com/tendermint/tendermint/crypto" "github.com/tendermint/tendermint/crypto/multisig" "github.com/tendermint/tendermint/libs/cli" @@ -97,7 +98,7 @@ func runAddCmd(cmd *cobra.Command, args []string) error { name := args[0] interactive := viper.GetBool(flagInteractive) - showMnemonic := viper.GetBool(flagNoBackup) + showMnemonic := !viper.GetBool(flagNoBackup) if viper.GetBool(flagDryRun) { // we throw this away, so don't enforce args,