From 1555c4876e15fe23712e241a6fe901a048b12244 Mon Sep 17 00:00:00 2001
From: rigelrozanski <rigel.rozanski@gmail.com>
Date: Thu, 15 Feb 2018 16:00:57 +0000
Subject: [PATCH] pretty good refactor

---
 examples/basecoin/app/app.go | 74 ++++++++++++++----------------------
 x/auth/mapper.go             |  9 +++--
 2 files changed, 33 insertions(+), 50 deletions(-)

diff --git a/examples/basecoin/app/app.go b/examples/basecoin/app/app.go
index 3b02b8519a..feb0349269 100644
--- a/examples/basecoin/app/app.go
+++ b/examples/basecoin/app/app.go
@@ -16,8 +16,6 @@ import (
 	cmn "github.com/tendermint/tmlibs/common"
 )
 
-const appName = "BasecoinApp"
-
 // Extended ABCI application
 type BasecoinApp struct {
 	*bam.BaseApp
@@ -33,63 +31,47 @@ type BasecoinApp struct {
 
 func NewBasecoinApp(genesisPath string) *BasecoinApp {
 
-	// define some keys
-	mainKey := sdk.NewKVStoreKey("main")
-	ibcKey := sdk.NewKVStoreKey("ibc")
-
-	// define a mapper
-	accountMapper := auth.NewAccountMapper(
-		mainKey,             // target store
-		&types.AppAccount{}, // prototype
-	)
-	cdc := accountMapper.WireCodec()
-	auth.RegisterWireBaseAccount(cdc)
-
 	// create your application object
 	var app = &BasecoinApp{
-		BaseApp:         bam.NewBaseApp(appName),
-		cdc:             makeTxCodec(),
-		capKeyMainStore: mainKey,
-		capKeyIBCStore:  ibcKey,
+		BaseApp:         bam.NewBaseApp("BasecoinApp"),
+		cdc:             MakeTxCodec(),
+		capKeyMainStore: sdk.NewKVStoreKey("main"),
+		capKeyIBCStore:  sdk.NewKVStoreKey("ibc"),
 	}
 
-	// Make accountMapper's WireCodec() inaccessible.
-	app.accountMapper = accountMapper.Seal()
-
-	app.initBaseAppTxDecoder()
-	app.initBaseAppInitStater(genesisPath)
-
-	app.MountStoresIAVL(app.capKeyMainStore, app.capKeyIBCStore)
+	// define the accountMapper
+	app.accountMapper = auth.NewAccountMapperSealed(
+		app.capKeyMainStore, // target store
+		&types.AppAccount{}, // prototype
+	)
 
 	// add handlers
-	app.SetAnteHandler(auth.NewAnteHandler(accountMapper))
-	app.Router().AddRoute("bank", bank.NewHandler(bank.NewCoinKeeper(accountMapper)))
+	app.Router().AddRoute("bank", bank.NewHandler(bank.NewCoinKeeper(app.accountMapper)))
 	app.Router().AddRoute("sketchy", sketchy.NewHandler())
 
-	// load the stores
-	if err := app.LoadLatestVersion(app.capKeyMainStore); err != nil {
+	// initialize BaseApp
+	app.SetTxDecoder()
+	app.SetInitStater(genesisPath)
+	app.MountStoresIAVL(app.capKeyMainStore, app.capKeyIBCStore)
+	app.SetAnteHandler(auth.NewAnteHandler(app.accountMapper))
+	err := app.LoadLatestVersion(app.capKeyMainStore)
+	if err != nil {
 		cmn.Exit(err.Error())
 	}
 
 	return app
 }
 
-// Wire requires registration of interfaces & concrete types. All
-// interfaces to be encoded/decoded in a Msg must be registered
-// here, along with all the concrete types that implement them.
-func makeTxCodec() (cdc *wire.Codec) {
-	cdc = wire.NewCodec()
-
-	// Register crypto.[PubKey,PrivKey,Signature] types.
-	crypto.RegisterWire(cdc)
-
-	// Register bank.[SendMsg,IssueMsg] types.
-	bank.RegisterWire(cdc)
-
-	return
+// custom tx codec
+func MakeTxCodec() *wire.Codec {
+	cdc := wire.NewCodec()
+	crypto.RegisterWire(cdc) // Register crypto.[PubKey,PrivKey,Signature] types.
+	bank.RegisterWire(cdc)   // Register bank.[SendMsg,IssueMsg] types.
+	return cdc
 }
 
-func (app *BasecoinApp) initBaseAppTxDecoder() {
+// custom logic for transaction decoding
+func (app *BasecoinApp) SetTxDecoder() {
 	app.BaseApp.SetTxDecoder(func(txBytes []byte) (sdk.Tx, sdk.Error) {
 		var tx = sdk.StdTx{}
 		// StdTx.Msg is an interface whose concrete
@@ -102,9 +84,10 @@ func (app *BasecoinApp) initBaseAppTxDecoder() {
 	})
 }
 
-// define the custom logic for basecoin initialization
-func (app *BasecoinApp) initBaseAppInitStater(genesisPath string) {
+// custom logic for basecoin initialization
+func (app *BasecoinApp) SetInitStater(genesisPath string) {
 
+	// TODO remove, use state ABCI
 	genesisAppState, err := bam.LoadGenesisAppState(genesisPath)
 	if err != nil {
 		panic(fmt.Errorf("error loading genesis state: %v", err))
@@ -116,7 +99,6 @@ func (app *BasecoinApp) initBaseAppInitStater(genesisPath string) {
 		if state == nil {
 			state = genesisAppState
 		}
-
 		if state == nil {
 			return nil
 		}
diff --git a/x/auth/mapper.go b/x/auth/mapper.go
index fb69975f85..6cd51552c7 100644
--- a/x/auth/mapper.go
+++ b/x/auth/mapper.go
@@ -36,8 +36,8 @@ func NewAccountMapper(key sdk.StoreKey, proto sdk.Account) accountMapper {
 	}
 }
 
-// XXX add comment
-func NewAccountMapperSealed(key sdk.StoreKey, proto sdk.Account) accountMapper {
+// Create and return a sealed account mapper
+func NewAccountMapperSealed(key sdk.StoreKey, proto sdk.Account) sealedAccountMapper {
 	cdc := wire.NewCodec()
 	am := accountMapper{
 		key:   key,
@@ -45,8 +45,9 @@ func NewAccountMapperSealed(key sdk.StoreKey, proto sdk.Account) accountMapper {
 		cdc:   cdc,
 	}
 	RegisterWireBaseAccount(cdc)
-	am.Seal()
-	return am
+
+	// make accountMapper's WireCodec() inaccessible, return
+	return am.Seal()
 }
 
 // Returns the go-wire codec.  You may need to register interfaces