x/bank: fix test
This commit is contained in:
Ethan Buchman
parent
1b82ff7a9a
commit
124f93b20f
@ -10,7 +10,7 @@ import (
|
||||
sdk "github.com/cosmos/cosmos-sdk/types"
|
||||
)
|
||||
|
||||
func TestTxInputValidation(t *testing.T) {
|
||||
func TestInputValidation(t *testing.T) {
|
||||
addr1 := crypto.Address([]byte{1, 2})
|
||||
addr2 := crypto.Address([]byte{7, 8})
|
||||
someCoins := sdk.Coins{{"atom", 123}}
|
||||
@ -26,22 +26,22 @@ func TestTxInputValidation(t *testing.T) {
|
||||
|
||||
cases := []struct {
|
||||
valid bool
|
||||
txIn TxInput
|
||||
txIn Input
|
||||
}{
|
||||
// auth works with different apps
|
||||
{true, NewTxInput(addr1, someCoins)},
|
||||
{true, NewTxInputWithSequence(addr1, someCoins, 100)},
|
||||
{true, NewTxInputWithSequence(addr2, someCoins, 100)},
|
||||
{true, NewTxInputWithSequence(addr2, multiCoins, 100)},
|
||||
{true, NewInput(addr1, someCoins)},
|
||||
{true, NewInputWithSequence(addr1, someCoins, 100)},
|
||||
{true, NewInputWithSequence(addr2, someCoins, 100)},
|
||||
{true, NewInputWithSequence(addr2, multiCoins, 100)},
|
||||
|
||||
{false, NewTxInput(emptyAddr, someCoins)}, // empty address
|
||||
{false, NewTxInputWithSequence(addr1, someCoins, -1)}, // negative sequence
|
||||
{false, NewTxInput(addr1, emptyCoins)}, // invalid coins
|
||||
{false, NewTxInput(addr1, emptyCoins2)}, // invalid coins
|
||||
{false, NewTxInput(addr1, someEmptyCoins)}, // invalid coins
|
||||
{false, NewTxInput(addr1, minusCoins)}, // negative coins
|
||||
{false, NewTxInput(addr1, someMinusCoins)}, // negative coins
|
||||
{false, NewTxInput(addr1, unsortedCoins)}, // unsorted coins
|
||||
{false, NewInput(emptyAddr, someCoins)}, // empty address
|
||||
{false, NewInputWithSequence(addr1, someCoins, -1)}, // negative sequence
|
||||
{false, NewInput(addr1, emptyCoins)}, // invalid coins
|
||||
{false, NewInput(addr1, emptyCoins2)}, // invalid coins
|
||||
{false, NewInput(addr1, someEmptyCoins)}, // invalid coins
|
||||
{false, NewInput(addr1, minusCoins)}, // negative coins
|
||||
{false, NewInput(addr1, someMinusCoins)}, // negative coins
|
||||
{false, NewInput(addr1, unsortedCoins)}, // unsorted coins
|
||||
}
|
||||
|
||||
for i, tc := range cases {
|
||||
@ -54,7 +54,7 @@ func TestTxInputValidation(t *testing.T) {
|
||||
}
|
||||
}
|
||||
|
||||
func TestTxOutputValidation(t *testing.T) {
|
||||
func TestOutputValidation(t *testing.T) {
|
||||
addr1 := crypto.Address([]byte{1, 2})
|
||||
addr2 := crypto.Address([]byte{7, 8})
|
||||
someCoins := sdk.Coins{{"atom", 123}}
|
||||
@ -70,20 +70,20 @@ func TestTxOutputValidation(t *testing.T) {
|
||||
|
||||
cases := []struct {
|
||||
valid bool
|
||||
txOut TxOutput
|
||||
txOut Output
|
||||
}{
|
||||
// auth works with different apps
|
||||
{true, NewTxOutput(addr1, someCoins)},
|
||||
{true, NewTxOutput(addr2, someCoins)},
|
||||
{true, NewTxOutput(addr2, multiCoins)},
|
||||
{true, NewOutput(addr1, someCoins)},
|
||||
{true, NewOutput(addr2, someCoins)},
|
||||
{true, NewOutput(addr2, multiCoins)},
|
||||
|
||||
{false, NewTxOutput(emptyAddr, someCoins)}, // empty address
|
||||
{false, NewTxOutput(addr1, emptyCoins)}, // invalid coins
|
||||
{false, NewTxOutput(addr1, emptyCoins2)}, // invalid coins
|
||||
{false, NewTxOutput(addr1, someEmptyCoins)}, // invalid coins
|
||||
{false, NewTxOutput(addr1, minusCoins)}, // negative coins
|
||||
{false, NewTxOutput(addr1, someMinusCoins)}, // negative coins
|
||||
{false, NewTxOutput(addr1, unsortedCoins)}, // unsorted coins
|
||||
{false, NewOutput(emptyAddr, someCoins)}, // empty address
|
||||
{false, NewOutput(addr1, emptyCoins)}, // invalid coins
|
||||
{false, NewOutput(addr1, emptyCoins2)}, // invalid coins
|
||||
{false, NewOutput(addr1, someEmptyCoins)}, // invalid coins
|
||||
{false, NewOutput(addr1, minusCoins)}, // negative coins
|
||||
{false, NewOutput(addr1, someMinusCoins)}, // negative coins
|
||||
{false, NewOutput(addr1, unsortedCoins)}, // unsorted coins
|
||||
}
|
||||
|
||||
for i, tc := range cases {
|
||||
@ -96,7 +96,7 @@ func TestTxOutputValidation(t *testing.T) {
|
||||
}
|
||||
}
|
||||
|
||||
func TestSendTxValidation(t *testing.T) {
|
||||
func TestSendMsgValidation(t *testing.T) {
|
||||
|
||||
addr1 := crypto.Address([]byte{1, 2})
|
||||
addr2 := crypto.Address([]byte{7, 8})
|
||||
@ -105,53 +105,53 @@ func TestSendTxValidation(t *testing.T) {
|
||||
eth123 := sdk.Coins{{"eth", 123}}
|
||||
atom123eth123 := sdk.Coins{{"atom", 123}, {"eth", 123}}
|
||||
|
||||
input1 := NewTxInput(addr1, atom123)
|
||||
input2 := NewTxInput(addr1, eth123)
|
||||
output1 := NewTxOutput(addr2, atom123)
|
||||
output2 := NewTxOutput(addr2, atom124)
|
||||
output3 := NewTxOutput(addr2, eth123)
|
||||
outputMulti := NewTxOutput(addr2, atom123eth123)
|
||||
input1 := NewInput(addr1, atom123)
|
||||
input2 := NewInput(addr1, eth123)
|
||||
output1 := NewOutput(addr2, atom123)
|
||||
output2 := NewOutput(addr2, atom124)
|
||||
output3 := NewOutput(addr2, eth123)
|
||||
outputMulti := NewOutput(addr2, atom123eth123)
|
||||
|
||||
var emptyAddr crypto.Address
|
||||
|
||||
cases := []struct {
|
||||
valid bool
|
||||
tx SendTx
|
||||
tx SendMsg
|
||||
}{
|
||||
{false, SendTx{}}, // no input or output
|
||||
{false, SendTx{Inputs: []TxInput{input1}}}, // just input
|
||||
{false, SendTx{Outputs: []TxOutput{output1}}}, // just ouput
|
||||
{false, SendTx{
|
||||
Inputs: []TxInput{NewTxInputWithSequence(emptyAddr, atom123, 1)}, // invalid input
|
||||
Outputs: []TxOutput{output1}}},
|
||||
{false, SendTx{
|
||||
Inputs: []TxInput{input1},
|
||||
Outputs: []TxOutput{{emptyAddr, atom123}}}, // invalid ouput
|
||||
{false, SendMsg{}}, // no input or output
|
||||
{false, SendMsg{Inputs: []Input{input1}}}, // just input
|
||||
{false, SendMsg{Outputs: []Output{output1}}}, // just ouput
|
||||
{false, SendMsg{
|
||||
Inputs: []Input{NewInputWithSequence(emptyAddr, atom123, 1)}, // invalid input
|
||||
Outputs: []Output{output1}}},
|
||||
{false, SendMsg{
|
||||
Inputs: []Input{input1},
|
||||
Outputs: []Output{{emptyAddr, atom123}}}, // invalid ouput
|
||||
},
|
||||
{false, SendTx{
|
||||
Inputs: []TxInput{input1},
|
||||
Outputs: []TxOutput{output2}}, // amounts dont match
|
||||
{false, SendMsg{
|
||||
Inputs: []Input{input1},
|
||||
Outputs: []Output{output2}}, // amounts dont match
|
||||
},
|
||||
{false, SendTx{
|
||||
Inputs: []TxInput{input1},
|
||||
Outputs: []TxOutput{output3}}, // amounts dont match
|
||||
{false, SendMsg{
|
||||
Inputs: []Input{input1},
|
||||
Outputs: []Output{output3}}, // amounts dont match
|
||||
},
|
||||
{false, SendTx{
|
||||
Inputs: []TxInput{input1},
|
||||
Outputs: []TxOutput{outputMulti}}, // amounts dont match
|
||||
{false, SendMsg{
|
||||
Inputs: []Input{input1},
|
||||
Outputs: []Output{outputMulti}}, // amounts dont match
|
||||
},
|
||||
{false, SendTx{
|
||||
Inputs: []TxInput{input2},
|
||||
Outputs: []TxOutput{output1}}, // amounts dont match
|
||||
{false, SendMsg{
|
||||
Inputs: []Input{input2},
|
||||
Outputs: []Output{output1}}, // amounts dont match
|
||||
},
|
||||
|
||||
{true, SendTx{
|
||||
Inputs: []TxInput{input1},
|
||||
Outputs: []TxOutput{output1}},
|
||||
{true, SendMsg{
|
||||
Inputs: []Input{input1},
|
||||
Outputs: []Output{output1}},
|
||||
},
|
||||
{true, SendTx{
|
||||
Inputs: []TxInput{input1, input2},
|
||||
Outputs: []TxOutput{outputMulti}},
|
||||
{true, SendMsg{
|
||||
Inputs: []Input{input1, input2},
|
||||
Outputs: []Output{outputMulti}},
|
||||
},
|
||||
}
|
||||
|
||||
@ -165,7 +165,9 @@ func TestSendTxValidation(t *testing.T) {
|
||||
}
|
||||
}
|
||||
|
||||
func TestSendTxSigners(t *testing.T) {
|
||||
/*
|
||||
// TODO where does this test belong ?
|
||||
func TestSendMsgSigners(t *testing.T) {
|
||||
signers := []crypto.Address{
|
||||
{1, 2, 3},
|
||||
{4, 5, 6},
|
||||
@ -173,11 +175,12 @@ func TestSendTxSigners(t *testing.T) {
|
||||
}
|
||||
|
||||
someCoins := sdk.Coins{{"atom", 123}}
|
||||
inputs := make([]TxInput, len(signers))
|
||||
inputs := make([]Input, len(signers))
|
||||
for i, signer := range signers {
|
||||
inputs[i] = NewTxInput(signer, someCoins)
|
||||
inputs[i] = NewInput(signer, someCoins)
|
||||
}
|
||||
tx := NewSendTx(inputs, nil)
|
||||
tx := NewSendMsg(inputs, nil)
|
||||
|
||||
assert.Equal(t, signers, tx.Signers())
|
||||
}
|
||||
*/
|
||||
|
||||
Loading…
Reference in New Issue
Block a user