fix: allow grpc server enabled even when api off (#14890)

This commit is contained in:
Julien Robert 2023-02-02 20:34:46 +01:00 committed by GitHub
parent 79f51403a9
commit 12394c8b99
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 14 additions and 2 deletions

View File

@ -442,6 +442,7 @@ jobs:
id: git_diff
with:
PATTERNS: |
contrib/rosetta/*
tools/rosetta/**/*.go
tools/rosetta/go.mod
tools/rosetta/go.sum

View File

@ -33,7 +33,7 @@ sed -i 's/127.0.0.1/0.0.0.0/g' /root/.simapp/config/config.toml
# start simd
echo starting simd...
simd start --pruning=nothing --api.enable true &
simd start --pruning=nothing &
pid=$!
echo simd started with PID $pid

View File

@ -3,7 +3,7 @@ version: "3"
services:
cosmos:
image: rosetta-ci:latest
command: ["simd", "start", "--pruning", "nothing", "--grpc.enable", "true", "--grpc.address", "0.0.0.0:9090", "--grpc-web.enable", "true", "--api.enable", "true"]
command: ["simd", "start", "--pruning", "nothing", "--grpc.enable", "true", "--grpc.address", "0.0.0.0:9090", "--grpc-web.enable", "true"]
ports:
- 9090:9090
- 26657:26657

View File

@ -441,6 +441,17 @@ func startInProcess(ctx *Context, clientCtx client.Context, appCreator types.App
}
}
// If gRPC is enabled but API is not, we need to start the gRPC server
// without the API server. If the API server is enabled, we've already
// started the grpc server.
if config.GRPC.Enable && !config.API.Enable {
grpcSrv, err = servergrpc.StartGRPCServer(clientCtx, app, config.GRPC)
if err != nil {
return err
}
defer grpcSrv.Stop()
}
// At this point it is safe to block the process if we're in gRPC only mode as
// we do not need to handle any Tendermint related processes.
if gRPCOnly {