address rigels review

examples/basecoin/app/app.go

@@ -61,10 +61,10 @@ func NewBasecoinApp(logger log.Logger, db dbm.DB) *BasecoinApp {
 	ibcMapper := ibc.NewIBCMapper(app.cdc, app.capKeyIBCStore)
 	stakeKeeper := staking.NewKeeper(app.capKeyStakingStore, coinKeeper)
 	app.Router().
-		AddRoute("bank", coinKeeper.Handler).
-		AddRoute("cool", coolKeeper.Handler).
+		AddRoute("bank", bank.NewHandler(coinKeeper)).
+		AddRoute("cool", cool.NewHandler(coolKeeper)).
 		AddRoute("ibc", ibc.NewHandler(ibcMapper, coinKeeper)).
-		AddRoute("staking", stakeKeeper.Handler)
+		AddRoute("staking", staking.NewHandler(stakeKeeper))
 
 	// initialize BaseApp
 	app.SetTxDecoder(app.txDecoder)

examples/basecoin/x/cool/errors.go

@@ -11,5 +11,5 @@ const (
 
 // ErrIncorrectCoolAnswer - Error returned upon an incorrect guess
 func ErrIncorrectCoolAnswer(answer string) sdk.Error {
-	return sdk.NewError(CodeIncorrectCoolAnswer, "Incorrect Cool answer - `"+answer+"'")
+	return sdk.NewError(CodeIncorrectCoolAnswer, "Incorrect cool answer")
 }

examples/basecoin/x/cool/handler.go

@@ -17,16 +17,18 @@ import (
 //|  $$$$$$$|  $$$$$$/|  $$$$$$/| $$$$$$$
 // \_______/ \______/  \______/ |______/
 
-// Handle all "coolmodule" type objects
-func (k Keeper) Handler(ctx sdk.Context, msg sdk.Msg) sdk.Result {
-	switch msg := msg.(type) {
-	case SetTrendMsg:
-		return handleSetTrendMsg(ctx, k, msg)
-	case QuizMsg:
-		return handleQuizMsg(ctx, k, msg)
-	default:
-		errMsg := fmt.Sprintf("Unrecognized cool Msg type: %v", reflect.TypeOf(msg).Name())
-		return sdk.ErrUnknownRequest(errMsg).Result()
+// NewHandler returns a handler for "cool" type messages.
+func NewHandler(k Keeper) sdk.Handler {
+	return func(ctx sdk.Context, msg sdk.Msg) sdk.Result {
+		switch msg := msg.(type) {
+		case SetTrendMsg:
+			return handleSetTrendMsg(ctx, k, msg)
+		case QuizMsg:
+			return handleQuizMsg(ctx, k, msg)
+		default:
+			errMsg := fmt.Sprintf("Unrecognized cool Msg type: %v", reflect.TypeOf(msg).Name())
+			return sdk.ErrUnknownRequest(errMsg).Result()
+		}
 	}
 }