chore: fix linting issues exposed by fixing golangci-lint (#12895)

Co-authored-by: Marko <marbar3778@yahoo.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>

server/mock/helpers.go

@@ -2,7 +2,6 @@ package mock
 
 import (
 	"fmt"
-	"io/ioutil"
 	"os"
 
 	"github.com/rs/zerolog"
@@ -23,7 +22,7 @@ func SetupApp() (abci.Application, func(), error) {
 	}
 	logger = logger.With("module", "mock")
 
-	rootDir, err := ioutil.TempDir("", "mock-sdk")
+	rootDir, err := os.MkdirTemp("", "mock-sdk")
 	if err != nil {
 		return nil, nil, err
 	}

server/mock/tx.go

@@ -1,4 +1,3 @@
-//nolint
 package mock
 
 import (
@@ -70,7 +69,7 @@ func decodeTx(txBytes []byte) (sdk.Tx, error) {
 	var tx sdk.Tx
 
 	split := bytes.Split(txBytes, []byte("="))
-	if len(split) == 1 {
+	if len(split) == 1 { //nolint:gocritic
 		k := split[0]
 		tx = kvstoreTx{k, k, txBytes}
 	} else if len(split) == 2 {