chore: fix linting issues exposed by fixing golangci-lint (#12895)

Co-authored-by: Marko <marbar3778@yahoo.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>

crypto/armor.go

@@ -4,11 +4,11 @@ import (
 	"bytes"
 	"encoding/hex"
 	"fmt"
-	"io/ioutil"
+	"io"
 
 	"github.com/tendermint/crypto/bcrypt"
 	"github.com/tendermint/tendermint/crypto"
-	"golang.org/x/crypto/openpgp/armor" // nolint: staticcheck
+	"golang.org/x/crypto/openpgp/armor" //nolint: staticcheck
 
 	"github.com/cosmos/cosmos-sdk/codec/legacy"
 	cryptotypes "github.com/cosmos/cosmos-sdk/crypto/types"
@@ -235,7 +235,7 @@ func DecodeArmor(armorStr string) (blockType string, headers map[string]string,
 	if err != nil {
 		return "", nil, nil, err
 	}
-	data, err = ioutil.ReadAll(block.Body)
+	data, err = io.ReadAll(block.Body)
 	if err != nil {
 		return "", nil, nil, err
 	}

crypto/hd/doc.go

@@ -1,8 +1,9 @@
 // Package hd provides support for hierarchical deterministic wallets generation and derivation.
 //
 // The user must understand the overall concept of the BIP 32 and the BIP 44 specs:
-//  https://github.com/bitcoin/bips/blob/master/bip-0044.mediawiki
-//  https://github.com/bitcoin/bips/blob/master/bip-0032.mediawiki
+//
+//	https://github.com/bitcoin/bips/blob/master/bip-0044.mediawiki
+//	https://github.com/bitcoin/bips/blob/master/bip-0032.mediawiki
 //
 // In combination with the bip39 package in go-crypto this package provides the functionality for
 // deriving keys using a BIP 44 HD path, or, more general, by passing a BIP 32 path.

crypto/hd/hdpath.go

@@ -215,7 +215,7 @@ func DerivePrivateKeyForPath(privKeyBytes, chainCode [32]byte, path string) ([]b
 // If harden is true, the derivation is 'hardened'.
 // It returns the new private key and new chain code.
 // For more information on hardened keys see:
-//  - https://github.com/bitcoin/bips/blob/master/bip-0032.mediawiki
+//   - https://github.com/bitcoin/bips/blob/master/bip-0032.mediawiki
 func derivePrivateKey(privKeyBytes [32]byte, chainCode [32]byte, index uint32, harden bool) ([32]byte, [32]byte) {
 	var data []byte
 

crypto/keyring/doc.go

@@ -1,19 +1,18 @@
 // Package keys provides common key management API.
 //
-//
-// The Keyring interface
+// # The Keyring interface
 //
 // The Keyring interface defines the methods that a type needs to implement to be used
 // as key storage backend. This package provides few implementations out-of-the-box.
 //
-// NewInMemory
+// # NewInMemory
 //
 // The NewInMemory constructor returns an implementation backed by an in-memory, goroutine-safe
 // map that has historically been used for testing purposes or on-the-fly key generation as the
 // generated keys are discarded when the process terminates or the type instance is garbage
 // collected.
 //
-// New
+// # New
 //
 // The New constructor returns an implementation backed by a keyring library
 // (https://github.com/99designs/keyring), whose aim is to provide a common abstraction and uniform
@@ -21,20 +20,21 @@
 // as well as operating system-agnostic encrypted file-based backends.
 //
 // The backends:
-// 	os		The instance returned by this constructor uses the operating system's default
-// 			credentials store to handle keys storage operations securely. It should be noted
-// 			that the keyring keyring may be kept unlocked for the whole duration of the user
-// 			session.
-// 	file	This backend more closely resembles the previous keyring storage used prior to
-// 			v0.38.1. It stores the keyring encrypted within the app's configuration directory.
-// 			This keyring will request a password each time it is accessed, which may occur
-// 			multiple times in a single command resulting in repeated password prompts.
-// 	kwallet	This backend uses KDE Wallet Manager as a credentials management application:
-// 			https://github.com/KDE/kwallet
-// 	pass	This backend uses the pass command line utility to store and retrieve keys:
-// 			https://www.passwordstore.org/
-// 	test	This backend stores keys insecurely to disk. It does not prompt for a password to
-// 			be unlocked and it should be use only for testing purposes.
-// 	memory	Same instance as returned by NewInMemory. This backend uses a transient storage. Keys
-// 			are discarded when the process terminates or the type instance is garbage collected.
+//
+//	os		The instance returned by this constructor uses the operating system's default
+//			credentials store to handle keys storage operations securely. It should be noted
+//			that the keyring keyring may be kept unlocked for the whole duration of the user
+//			session.
+//	file	This backend more closely resembles the previous keyring storage used prior to
+//			v0.38.1. It stores the keyring encrypted within the app's configuration directory.
+//			This keyring will request a password each time it is accessed, which may occur
+//			multiple times in a single command resulting in repeated password prompts.
+//	kwallet	This backend uses KDE Wallet Manager as a credentials management application:
+//			https://github.com/KDE/kwallet
+//	pass	This backend uses the pass command line utility to store and retrieve keys:
+//			https://www.passwordstore.org/
+//	test	This backend stores keys insecurely to disk. It does not prompt for a password to
+//			be unlocked and it should be use only for testing purposes.
+//	memory	Same instance as returned by NewInMemory. This backend uses a transient storage. Keys
+//			are discarded when the process terminates or the type instance is garbage collected.
 package keyring

crypto/keyring/output.go

@@ -21,7 +21,7 @@ type KeyOutput struct {
 }
 
 // NewKeyOutput creates a default KeyOutput instance without Mnemonic, Threshold and PubKeys
-func NewKeyOutput(name string, keyType KeyType, a sdk.Address, pk cryptotypes.PubKey) (KeyOutput, error) { // nolint:interfacer
+func NewKeyOutput(name string, keyType KeyType, a sdk.Address, pk cryptotypes.PubKey) (KeyOutput, error) { //nolint:interfacer
 	apk, err := codectypes.NewAnyWithValue(pk)
 	if err != nil {
 		return KeyOutput{}, err

crypto/keys/multisig/codec.go

@@ -15,8 +15,7 @@ const (
 	PubKeyAminoRoute = "tendermint/PubKeyMultisigThreshold"
 )
 
-//nolint
-// Deprecated: Amino is being deprecated in the SDK. But even if you need to
+// AminoCdc is being deprecated in the SDK. But even if you need to
 // use Amino for some reason, please use `codec/legacy.Cdc` instead.
 var AminoCdc = codec.NewLegacyAmino()
 

crypto/keys/secp256k1/secp256k1.go

@@ -10,7 +10,7 @@ import (
 
 	secp256k1 "github.com/btcsuite/btcd/btcec"
 	"github.com/tendermint/tendermint/crypto"
-	"golang.org/x/crypto/ripemd160" // nolint: staticcheck // necessary for Bitcoin address format
+	"golang.org/x/crypto/ripemd160" //nolint: staticcheck // necessary for Bitcoin address format
 
 	"github.com/cosmos/cosmos-sdk/codec"
 	cryptotypes "github.com/cosmos/cosmos-sdk/crypto/types"

crypto/keys/secp256k1/secp256k1_nocgo.go

@@ -13,8 +13,8 @@ import (
 
 // used to reject malleable signatures
 // see:
-//  - https://github.com/ethereum/go-ethereum/blob/f9401ae011ddf7f8d2d95020b7446c17f8d98dc1/crypto/signature_nocgo.go#L90-L93
-//  - https://github.com/ethereum/go-ethereum/blob/f9401ae011ddf7f8d2d95020b7446c17f8d98dc1/crypto/crypto.go#L39
+//   - https://github.com/ethereum/go-ethereum/blob/f9401ae011ddf7f8d2d95020b7446c17f8d98dc1/crypto/signature_nocgo.go#L90-L93
+//   - https://github.com/ethereum/go-ethereum/blob/f9401ae011ddf7f8d2d95020b7446c17f8d98dc1/crypto/crypto.go#L39
 var secp256k1halfN = new(big.Int).Rsh(secp256k1.S256().N, 1)
 
 // Sign creates an ECDSA signature on curve Secp256k1, using SHA256 on the msg.