From f355f63df9e7336e562cb4dc04109f10c992b0b2 Mon Sep 17 00:00:00 2001 From: willclarktech Date: Wed, 24 Jun 2020 17:56:51 +0200 Subject: [PATCH] stream: Remove tslint --- packages/stream/src/concat.spec.ts | 1 - packages/stream/src/concat.ts | 2 -- packages/stream/src/defaultvalueproducer.spec.ts | 2 -- packages/stream/src/defaultvalueproducer.ts | 6 ------ packages/stream/src/promise.spec.ts | 2 -- packages/stream/src/reducer.spec.ts | 1 - packages/stream/src/reducer.ts | 11 ----------- packages/stream/tslint.json | 3 --- 8 files changed, 28 deletions(-) delete mode 100644 packages/stream/tslint.json diff --git a/packages/stream/src/concat.spec.ts b/packages/stream/src/concat.spec.ts index 6653e45b..ef033505 100644 --- a/packages/stream/src/concat.spec.ts +++ b/packages/stream/src/concat.spec.ts @@ -1,4 +1,3 @@ -// tslint:disable:readonly-array no-submodule-imports import { Producer, Stream } from "xstream"; import { concat } from "./concat"; diff --git a/packages/stream/src/concat.ts b/packages/stream/src/concat.ts index 56befc7c..131e080f 100644 --- a/packages/stream/src/concat.ts +++ b/packages/stream/src/concat.ts @@ -1,4 +1,3 @@ -// tslint:disable:readonly-array import { Producer, Stream, Subscription } from "xstream"; /** @@ -31,7 +30,6 @@ export function concat(...streams: Stream[]): Stream { subscription.unsubscribe(); } - // tslint:disable-next-line:no-object-mutation queues.length = 0; completedStreams.clear(); activeStreamIndex = 0; diff --git a/packages/stream/src/defaultvalueproducer.spec.ts b/packages/stream/src/defaultvalueproducer.spec.ts index 2c2de53f..42bf74ff 100644 --- a/packages/stream/src/defaultvalueproducer.spec.ts +++ b/packages/stream/src/defaultvalueproducer.spec.ts @@ -29,7 +29,6 @@ describe("DefaultValueProducer", () => { const producer = new DefaultValueProducer(42); const stream = Stream.createWithMemory(producer); - // tslint:disable-next-line:readonly-array const events: number[] = []; stream.addListener({ next: (value) => { @@ -68,7 +67,6 @@ describe("DefaultValueProducer", () => { }); it("calls callbacks", async () => { - // tslint:disable-next-line:readonly-array const producerActive: boolean[] = []; const producer = new DefaultValueProducer(42, { diff --git a/packages/stream/src/defaultvalueproducer.ts b/packages/stream/src/defaultvalueproducer.ts index 8b04e4ab..56dafaf8 100644 --- a/packages/stream/src/defaultvalueproducer.ts +++ b/packages/stream/src/defaultvalueproducer.ts @@ -12,9 +12,7 @@ export class DefaultValueProducer implements Producer { } private readonly callbacks: DefaultValueProducerCallsbacks | undefined; - // tslint:disable-next-line:readonly-keyword private internalValue: T; - // tslint:disable-next-line:readonly-keyword private listener: Listener | undefined; public constructor(value: T, callbacks?: DefaultValueProducerCallsbacks) { @@ -29,7 +27,6 @@ export class DefaultValueProducer implements Producer { * If not, just the current value is updated. */ public update(value: T): void { - // tslint:disable-next-line:no-object-mutation this.internalValue = value; if (this.listener) { this.listener.next(value); @@ -49,7 +46,6 @@ export class DefaultValueProducer implements Producer { * Called by the stream. Do not call this directly. */ public start(listener: Listener): void { - // tslint:disable-next-line:no-object-mutation this.listener = listener; listener.next(this.internalValue); @@ -65,8 +61,6 @@ export class DefaultValueProducer implements Producer { if (this.callbacks) { this.callbacks.onStop(); } - - // tslint:disable-next-line:no-object-mutation this.listener = undefined; } } diff --git a/packages/stream/src/promise.spec.ts b/packages/stream/src/promise.spec.ts index 8c6696ea..3212998e 100644 --- a/packages/stream/src/promise.spec.ts +++ b/packages/stream/src/promise.spec.ts @@ -1,5 +1,3 @@ -// tslint:disable:readonly-array - import { Producer, Stream } from "xstream"; import { firstEvent, fromListPromise, toListPromise } from "./promise"; diff --git a/packages/stream/src/reducer.spec.ts b/packages/stream/src/reducer.spec.ts index e71755f9..45ff8906 100644 --- a/packages/stream/src/reducer.spec.ts +++ b/packages/stream/src/reducer.spec.ts @@ -1,4 +1,3 @@ -// tslint:disable:readonly-array import { Stream } from "xstream"; import { asArray, countStream, lastValue } from "./reducer"; diff --git a/packages/stream/src/reducer.ts b/packages/stream/src/reducer.ts index 9dd7848a..aa0a6f21 100644 --- a/packages/stream/src/reducer.ts +++ b/packages/stream/src/reducer.ts @@ -1,14 +1,3 @@ -/* -This file maintains some stream helpers used in iov-bns, but which -may be useful other places, and should consider to be moved. - -Reducer and related code works to maintain a current state -materialized by reducing all events on a stream. Similar -to ValueAndUpdate in keycontrol, but more general. -*/ - -// tslint:disable:readonly-keyword -// tslint:disable:no-object-mutation import { Stream } from "xstream"; export type ReducerFunc = (acc: U, evt: T) => U; diff --git a/packages/stream/tslint.json b/packages/stream/tslint.json deleted file mode 100644 index 0946f209..00000000 --- a/packages/stream/tslint.json +++ /dev/null @@ -1,3 +0,0 @@ -{ - "extends": "../../tslint.json" -}