LaconicNetwork/cosmjs-util
10
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 1 Wiki Activity

Merge pull request #1410 from cosmos/fix-pendingWithoutSimapp44Or46

Browse Source 
Remove unnecessary pendingWithoutSimapp44Or46
This commit is contained in:
Simon Warta 2023-04-06 17:14:58 +02:00 committed by GitHub
commit e8e65aa0c1
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 4 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
packages/stargate/src/modules/authz/queries.spec.ts
View File

@ -11,7 +11,7 @@ import {
defaultSigningClientOptions,
faucet,
makeRandomAddress,
pendingWithoutSimapp44Or46,
pendingWithoutSimapp,
pendingWithoutSimapp46,
simapp,
simapp44Enabled,
@ -81,7 +81,7 @@ describe("AuthzExtension", () => {
describe("grants", () => {
it("works", async () => {
pendingWithoutSimapp44Or46();
pendingWithoutSimapp();
const [client, tmClient] = await makeClientWithAuthz(simapp.tendermintUrl);
const response = await client.authz.grants(granter1Address, grantee1Address, "");
expect(response.grants.length).toEqual(1);

5
packages/stargate/src/modules/gov/messages.spec.ts
View File

@ -12,7 +12,6 @@ import {
faucet,
nonNegativeIntegerMatcher,
pendingWithoutSimapp,
pendingWithoutSimapp44Or46,
simapp,
simappEnabled,
validator,
@ -171,7 +170,7 @@ describe("gov messages", () => {
describe("MsgVoteWeighted", () => {
it("works", async () => {
pendingWithoutSimapp44Or46(); // MsgVoteWeighted does not yet exist in Cosmos SDK 0.42
pendingWithoutSimapp();
assert(voterWallet);
assert(proposalId, "Missing proposal ID");
const client = await SigningStargateClient.connectWithSigner(simapp.tendermintUrl, voterWallet);
@ -204,7 +203,7 @@ describe("gov messages", () => {
});
it("works with Amino JSON sign mode", async () => {
pendingWithoutSimapp44Or46(); // MsgVoteWeighted does not yet exist in Cosmos SDK 0.42
pendingWithoutSimapp();
assert(voterWalletAmino);
assert(proposalId, "Missing proposal ID");
const client = await SigningStargateClient.connectWithSigner(simapp.tendermintUrl, voterWalletAmino);

6
packages/stargate/src/testutils.spec.ts
View File

@ -27,12 +27,6 @@ export function simappEnabled(): boolean {
return simapp44Enabled() || simapp46Enabled();
}
export function pendingWithoutSimapp44Or46(): void {
if (!simapp44Enabled() && !simapp46Enabled()) {
return pending("Set SIMAPP{44,46}_ENABLED to enable Simapp based tests");
}
}
export function pendingWithoutSimapp46(): void {
if (!simapp46Enabled()) {
return pending("Set SIMAPP46_ENABLED to enable Simapp based tests");