From d9520990dd09053172d584856d7ad3401ddc71fd Mon Sep 17 00:00:00 2001
From: willclarktech <willclarktech@users.noreply.github.com>
Date: Wed, 12 Aug 2020 13:19:19 +0200
Subject: [PATCH] tendermint-rpc: Update BroadcastTxCommitResponse type

---
 packages/tendermint-rpc/src/responses.ts       | 10 +++++-----
 packages/tendermint-rpc/src/v0-33/responses.ts |  4 ++--
 packages/tendermint-rpc/types/responses.d.ts   |  8 ++++----
 3 files changed, 11 insertions(+), 11 deletions(-)

diff --git a/packages/tendermint-rpc/src/responses.ts b/packages/tendermint-rpc/src/responses.ts
index 049ad805..1eb25b6f 100644
--- a/packages/tendermint-rpc/src/responses.ts
+++ b/packages/tendermint-rpc/src/responses.ts
@@ -69,20 +69,20 @@ export function broadcastTxSyncSuccess(res: BroadcastTxSyncResponse): boolean {
 }
 
 export interface BroadcastTxCommitResponse {
-  readonly height?: number;
+  readonly height: number;
   readonly hash: TxHash;
   readonly checkTx: TxData;
   readonly deliverTx?: TxData;
 }
 
 /**
- * Returns true iff transaction made it sucessfully into a block
- * (i.e. sucess in `check_tx` and `deliver_tx` field)
+ * Returns true iff transaction made it successfully into a block
+ * (i.e. success in `check_tx` and `deliver_tx` field)
  */
-export function broadcastTxCommitSuccess(res: BroadcastTxCommitResponse): boolean {
+export function broadcastTxCommitSuccess(response: BroadcastTxCommitResponse): boolean {
   // code must be 0 on success
   // deliverTx may be present but empty on failure
-  return res.checkTx.code === 0 && !!res.deliverTx && res.deliverTx.code === 0;
+  return response.checkTx.code === 0 && !!response.deliverTx && response.deliverTx.code === 0;
 }
 
 export interface CommitResponse {
diff --git a/packages/tendermint-rpc/src/v0-33/responses.ts b/packages/tendermint-rpc/src/v0-33/responses.ts
index 76e12b5a..8e78ddcc 100644
--- a/packages/tendermint-rpc/src/v0-33/responses.ts
+++ b/packages/tendermint-rpc/src/v0-33/responses.ts
@@ -345,7 +345,7 @@ function decodeBroadcastTxSync(data: RpcBroadcastTxSyncResponse): responses.Broa
 }
 
 interface RpcBroadcastTxCommitResponse {
-  readonly height?: IntegerString;
+  readonly height: IntegerString;
   readonly hash: HexString;
   readonly check_tx: RpcTxData;
   readonly deliver_tx?: RpcTxData;
@@ -353,7 +353,7 @@ interface RpcBroadcastTxCommitResponse {
 
 function decodeBroadcastTxCommit(data: RpcBroadcastTxCommitResponse): responses.BroadcastTxCommitResponse {
   return {
-    height: may(Integer.parse, data.height),
+    height: Integer.parse(data.height),
     hash: fromHex(assertNotEmpty(data.hash)) as TxHash,
     checkTx: decodeTxData(assertObject(data.check_tx)),
     deliverTx: may(decodeTxData, data.deliver_tx),
diff --git a/packages/tendermint-rpc/types/responses.d.ts b/packages/tendermint-rpc/types/responses.d.ts
index ff55fb74..26446072 100644
--- a/packages/tendermint-rpc/types/responses.d.ts
+++ b/packages/tendermint-rpc/types/responses.d.ts
@@ -55,16 +55,16 @@ export interface BroadcastTxSyncResponse extends TxData {
  */
 export declare function broadcastTxSyncSuccess(res: BroadcastTxSyncResponse): boolean;
 export interface BroadcastTxCommitResponse {
-  readonly height?: number;
+  readonly height: number;
   readonly hash: TxHash;
   readonly checkTx: TxData;
   readonly deliverTx?: TxData;
 }
 /**
- * Returns true iff transaction made it sucessfully into a block
- * (i.e. sucess in `check_tx` and `deliver_tx` field)
+ * Returns true iff transaction made it successfully into a block
+ * (i.e. success in `check_tx` and `deliver_tx` field)
  */
-export declare function broadcastTxCommitSuccess(res: BroadcastTxCommitResponse): boolean;
+export declare function broadcastTxCommitSuccess(response: BroadcastTxCommitResponse): boolean;
 export interface CommitResponse {
   readonly header: Header;
   readonly commit: Commit;