Merge pull request #431 from CosmWasm/unnecessary-helpers

Tendermint: Remove unnecessary helpers

CHANGELOG.md

@@ -59,6 +59,9 @@
 - @cosmjs/tendermint-rpc: Remove obsolete `BlockResultsResponse.beginBlock` and
   `.beginBlock`. The new `.beginBlockEvents` and `.endBlockEvents` now parse the
   events correctly.
+- @cosmjs/tendermint-rpc: Remove trivial helpers `getTxEventHeight`,
+  `getHeaderEventHeight` and `getBlockEventHeight` because they don't do
+  anything else than accessing an object member.
 - @cosmjs/utils: Add `assertDefined`.
 - @cosmjs/faucet: Rename binary from `cosmwasm-faucet` to `cosmos-faucet`.
 

packages/tendermint-rpc/src/index.ts

@@ -27,7 +27,53 @@ export {
   TxSearchRequest,
   ValidatorsRequest,
 } from "./requests";
-export * from "./responses";
+export {
+  AbciInfoResponse,
+  AbciQueryResponse,
+  Attribute,
+  Block,
+  BlockchainResponse,
+  BlockGossipParams,
+  BlockId,
+  BlockMeta,
+  BlockParams,
+  BlockResponse,
+  BlockResultsResponse,
+  BroadcastTxAsyncResponse,
+  BroadcastTxCommitResponse,
+  broadcastTxCommitSuccess,
+  BroadcastTxSyncResponse,
+  broadcastTxSyncSuccess,
+  Commit,
+  CommitResponse,
+  ConsensusParams,
+  Event,
+  Evidence,
+  EvidenceParams,
+  GenesisResponse,
+  Header,
+  HealthResponse,
+  NewBlockEvent,
+  NewBlockHeaderEvent,
+  NodeInfo,
+  ProofOp,
+  QueryProof,
+  ReadonlyDateWithNanoseconds,
+  Response,
+  StatusResponse,
+  SyncInfo,
+  TxData,
+  TxEvent,
+  TxProof,
+  TxResponse,
+  TxSearchResponse,
+  TxSizeParams,
+  Validator,
+  ValidatorsResponse,
+  Version,
+  Vote,
+  VoteType,
+} from "./responses";
 export { HttpClient, WebsocketClient } from "./rpcclients"; // TODO: Why do we export those outside of this package?
 export {
   IpPortString,

packages/tendermint-rpc/src/responses.ts

@@ -157,10 +157,6 @@ export interface TxEvent {
   readonly result: TxData;
 }
 
-export const getTxEventHeight = (event: TxEvent): number => event.height;
-export const getHeaderEventHeight = (event: NewBlockHeaderEvent): number => event.height;
-export const getBlockEventHeight = (event: NewBlockEvent): number => event.header.height;
-
 // Helper items used above
 
 /** An event attribute */

packages/tendermint-rpc/types/index.d.ts

@@ -24,7 +24,53 @@ export {
   TxSearchRequest,
   ValidatorsRequest,
 } from "./requests";
-export * from "./responses";
+export {
+  AbciInfoResponse,
+  AbciQueryResponse,
+  Attribute,
+  Block,
+  BlockchainResponse,
+  BlockGossipParams,
+  BlockId,
+  BlockMeta,
+  BlockParams,
+  BlockResponse,
+  BlockResultsResponse,
+  BroadcastTxAsyncResponse,
+  BroadcastTxCommitResponse,
+  broadcastTxCommitSuccess,
+  BroadcastTxSyncResponse,
+  broadcastTxSyncSuccess,
+  Commit,
+  CommitResponse,
+  ConsensusParams,
+  Event,
+  Evidence,
+  EvidenceParams,
+  GenesisResponse,
+  Header,
+  HealthResponse,
+  NewBlockEvent,
+  NewBlockHeaderEvent,
+  NodeInfo,
+  ProofOp,
+  QueryProof,
+  ReadonlyDateWithNanoseconds,
+  Response,
+  StatusResponse,
+  SyncInfo,
+  TxData,
+  TxEvent,
+  TxProof,
+  TxResponse,
+  TxSearchResponse,
+  TxSizeParams,
+  Validator,
+  ValidatorsResponse,
+  Version,
+  Vote,
+  VoteType,
+} from "./responses";
 export { HttpClient, WebsocketClient } from "./rpcclients";
 export {
   IpPortString,

packages/tendermint-rpc/types/responses.d.ts

@@ -123,9 +123,6 @@ export interface TxEvent {
   readonly index: number;
   readonly result: TxData;
 }
-export declare const getTxEventHeight: (event: TxEvent) => number;
-export declare const getHeaderEventHeight: (event: NewBlockHeaderEvent) => number;
-export declare const getBlockEventHeight: (event: NewBlockEvent) => number;
 /** An event attribute */
 export interface Attribute {
   readonly key: Uint8Array;