From c1770dbe0cc802a5227e0dacf8ab2225f65b6f8a Mon Sep 17 00:00:00 2001
From: Simon Warta <simon@warta.it>
Date: Tue, 30 Jun 2020 08:45:07 +0200
Subject: [PATCH] Stabilize ID test for createJsonRpcRequest

---
 packages/tendermint-rpc/src/jsonrpc.spec.ts | 2 +-
 packages/tendermint-rpc/src/jsonrpc.ts      | 7 +++++--
 2 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/packages/tendermint-rpc/src/jsonrpc.spec.ts b/packages/tendermint-rpc/src/jsonrpc.spec.ts
index 557c70c0..2f86a235 100644
--- a/packages/tendermint-rpc/src/jsonrpc.spec.ts
+++ b/packages/tendermint-rpc/src/jsonrpc.spec.ts
@@ -5,7 +5,7 @@ describe("jsonrpc", () => {
     it("generates proper object with correct method", () => {
       const request = createJsonRpcRequest("do_something");
       expect(request.jsonrpc).toEqual("2.0");
-      expect(request.id.toString()).toMatch(/^[0-9]{10,12}$/);
+      expect(request.id.toString()).toMatch(/^[1-9]{12}$/);
       expect(request.method).toEqual("do_something");
     });
 
diff --git a/packages/tendermint-rpc/src/jsonrpc.ts b/packages/tendermint-rpc/src/jsonrpc.ts
index 6d9ed313..facf848f 100644
--- a/packages/tendermint-rpc/src/jsonrpc.ts
+++ b/packages/tendermint-rpc/src/jsonrpc.ts
@@ -1,12 +1,15 @@
 import { JsonRpcRequest } from "@cosmjs/json-rpc";
 
-const numbers = "0123456789";
+const numbersWithoutZero = "123456789";
 
 /** generates a random numeric character  */
 function randomNumericChar(): string {
-  return numbers[Math.floor(Math.random() * numbers.length)];
+  return numbersWithoutZero[Math.floor(Math.random() * numbersWithoutZero.length)];
 }
 
+/**
+ * An (absolutely not cryptographically secure) random integer > 0.
+ */
 function randomId(): number {
   return parseInt(
     Array.from({ length: 12 })