LaconicNetwork/cosmjs-util
10
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 1 Wiki Activity

Improve fromHex: avoid deprecated substr, write to output buffer directly

Browse Source
This commit is contained in:
Simon Warta 2022-01-29 20:50:26 +01:00
parent 138b11b514
commit aa804db064
1 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
packages/encoding/src/hex.ts
View File

@ -11,13 +11,14 @@ export function fromHex(hexstring: string): Uint8Array {
throw new Error("hex string length must be a multiple of 2");
}
const listOfInts: number[] = [];
for (let i = 0; i < hexstring.length; i += 2) {
const hexByteAsString = hexstring.substr(i, 2);
const out = new Uint8Array(hexstring.length / 2);
for (let i = 0; i < out.length; i++) {
const j = 2 * i;
const hexByteAsString = hexstring.slice(j, j + 2);
if (!hexByteAsString.match(/[0-9a-f]{2}/i)) {
throw new Error("hex string contains invalid characters");
}
listOfInts.push(parseInt(hexByteAsString, 16));
out[i] = parseInt(hexByteAsString, 16);
}
return new Uint8Array(listOfInts);
return out;
}