From a8c325ba62063da1a8d2007deb3470ceae4558b5 Mon Sep 17 00:00:00 2001
From: willclarktech <willclarktech@users.noreply.github.com>
Date: Tue, 6 Oct 2020 11:46:06 +0200
Subject: [PATCH] launchpad-ledger: Remove disconnect method

---
 packages/launchpad-ledger/src/launchpadledger.ts     | 11 +----------
 packages/launchpad-ledger/src/ledgersigner.spec.ts   |  6 ------
 packages/launchpad-ledger/src/ledgersigner.ts        |  4 ----
 packages/launchpad-ledger/types/launchpadledger.d.ts |  4 +---
 packages/launchpad-ledger/types/ledgersigner.d.ts    |  1 -
 5 files changed, 2 insertions(+), 24 deletions(-)

diff --git a/packages/launchpad-ledger/src/launchpadledger.ts b/packages/launchpad-ledger/src/launchpadledger.ts
index 0d296a0f..994c7800 100644
--- a/packages/launchpad-ledger/src/launchpadledger.ts
+++ b/packages/launchpad-ledger/src/launchpadledger.ts
@@ -36,8 +36,7 @@ export class LaunchpadLedger {
   private readonly testModeAllowed: boolean;
   private readonly hdPaths: readonly HdPath[];
   private readonly prefix: string;
-  private readonly transport: LedgerTransport;
-  private app: CosmosApp | null;
+  private readonly app: CosmosApp | null;
 
   public constructor(transport: LedgerTransport, options: LaunchpadLedgerOptions = {}) {
     const defaultOptions = {
@@ -52,7 +51,6 @@ export class LaunchpadLedger {
     this.testModeAllowed = testModeAllowed;
     this.hdPaths = hdPaths;
     this.prefix = prefix;
-    this.transport = transport;
     this.app = new CosmosApp(transport);
   }
 
@@ -103,13 +101,6 @@ export class LaunchpadLedger {
     return Secp256k1Signature.fromDer((response as SignResponse).signature).toFixedLength();
   }
 
-  public async disconnect(): Promise<void> {
-    if (this.app) {
-      await this.transport.close();
-      this.app = null;
-    }
-  }
-
   private verifyAppMode(testMode: boolean): void {
     if (testMode && !this.testModeAllowed) {
       throw new Error(`DANGER: The Cosmos Ledger app is in test mode and should not be used on mainnet!`);
diff --git a/packages/launchpad-ledger/src/ledgersigner.spec.ts b/packages/launchpad-ledger/src/ledgersigner.spec.ts
index 09fce517..38f96e64 100644
--- a/packages/launchpad-ledger/src/ledgersigner.spec.ts
+++ b/packages/launchpad-ledger/src/ledgersigner.spec.ts
@@ -74,8 +74,6 @@ describe("LedgerSigner", () => {
           pubkey: fromBase64("A2ZnLEcbpyjS30H5UF1vezq29aBcT9oo5EARATIW9Cpj"),
         },
       ]);
-
-      await signer.disconnect();
     });
   });
 
@@ -123,8 +121,6 @@ describe("LedgerSigner", () => {
           fistAccount.pubkey,
         );
         expect(valid).toEqual(true);
-
-        await signer.disconnect();
       },
       interactiveTimeout,
     );
@@ -144,8 +140,6 @@ describe("LedgerSigner", () => {
         const client = new SigningCosmosClient(wasmd.endpoint, fistAccount.address, signer);
         const result = await client.sendTokens(defaultRecipient, coins(1234567, "ucosm"));
         assert(isBroadcastTxSuccess(result));
-
-        await signer.disconnect();
       },
       interactiveTimeout,
     );
diff --git a/packages/launchpad-ledger/src/ledgersigner.ts b/packages/launchpad-ledger/src/ledgersigner.ts
index 6e548c07..7f74b9c0 100644
--- a/packages/launchpad-ledger/src/ledgersigner.ts
+++ b/packages/launchpad-ledger/src/ledgersigner.ts
@@ -53,8 +53,4 @@ export class LedgerSigner implements OfflineSigner {
       signature: encodeSecp256k1Signature(accountForAddress.pubkey, signature),
     };
   }
-
-  public async disconnect(): Promise<void> {
-    return this.ledger.disconnect();
-  }
 }
diff --git a/packages/launchpad-ledger/types/launchpadledger.d.ts b/packages/launchpad-ledger/types/launchpadledger.d.ts
index e2bb37d5..514eb9d2 100644
--- a/packages/launchpad-ledger/types/launchpadledger.d.ts
+++ b/packages/launchpad-ledger/types/launchpadledger.d.ts
@@ -14,15 +14,13 @@ export declare class LaunchpadLedger {
   private readonly testModeAllowed;
   private readonly hdPaths;
   private readonly prefix;
-  private readonly transport;
-  private app;
+  private readonly app;
   constructor(transport: LedgerTransport, options?: LaunchpadLedgerOptions);
   getCosmosAppVersion(): Promise<string>;
   getPubkey(hdPath?: HdPath): Promise<Uint8Array>;
   getPubkeys(): Promise<readonly Uint8Array[]>;
   getCosmosAddress(pubkey?: Uint8Array): Promise<string>;
   sign(message: Uint8Array, hdPath?: HdPath): Promise<Uint8Array>;
-  disconnect(): Promise<void>;
   private verifyAppMode;
   private getOpenAppName;
   private verifyAppVersion;
diff --git a/packages/launchpad-ledger/types/ledgersigner.d.ts b/packages/launchpad-ledger/types/ledgersigner.d.ts
index 63792bea..22f1302f 100644
--- a/packages/launchpad-ledger/types/ledgersigner.d.ts
+++ b/packages/launchpad-ledger/types/ledgersigner.d.ts
@@ -10,5 +10,4 @@ export declare class LedgerSigner implements OfflineSigner {
   constructor(transport: LedgerTransport, options?: LaunchpadLedgerOptions);
   getAccounts(): Promise<readonly AccountData[]>;
   sign(signerAddress: string, signDoc: StdSignDoc): Promise<SignResponse>;
-  disconnect(): Promise<void>;
 }