From 9705b98be91860f6b30d077bd4ee6b4e05bacc75 Mon Sep 17 00:00:00 2001 From: Simon Warta Date: Wed, 19 Feb 2020 09:42:20 +0100 Subject: [PATCH] Bring back no-bitwise --- .eslintrc.js | 1 + packages/bcp/src/types.ts | 2 ++ packages/sdk/src/testutils.spec.ts | 3 +++ 3 files changed, 6 insertions(+) diff --git a/.eslintrc.js b/.eslintrc.js index ca1e4e1d..8576e84b 100644 --- a/.eslintrc.js +++ b/.eslintrc.js @@ -21,6 +21,7 @@ module.exports = { ], rules: { curly: ["warn", "multi-line", "consistent"], + "no-bitwise": "warn", "no-console": ["warn", { allow: ["error", "info", "warn"] }], "no-param-reassign": "warn", "no-shadow": "warn", diff --git a/packages/bcp/src/types.ts b/packages/bcp/src/types.ts index 3e982ac1..7219b0d3 100644 --- a/packages/bcp/src/types.ts +++ b/packages/bcp/src/types.ts @@ -32,7 +32,9 @@ export interface Erc20Token { readonly fractionalDigits: number; } +// eslint-disable-next-line no-bitwise const maxAcct = 1 << 23; +// eslint-disable-next-line no-bitwise const maxSeq = 1 << 20; // this (lossily) encodes the two pieces of info (uint64) needed to sign into diff --git a/packages/sdk/src/testutils.spec.ts b/packages/sdk/src/testutils.spec.ts index 484543e9..20b5a1d2 100644 --- a/packages/sdk/src/testutils.spec.ts +++ b/packages/sdk/src/testutils.spec.ts @@ -11,10 +11,13 @@ export function leb128Encode(uint: number): Uint8Array { const out = new Array(); let value = uint; do { + // eslint-disable-next-line no-bitwise let byte = value & 0b01111111; + // eslint-disable-next-line no-bitwise value >>= 7; // more bytes to come: set high order bit of byte + // eslint-disable-next-line no-bitwise if (value !== 0) byte ^= 0b10000000; out.push(byte);