LaconicNetwork/cosmjs-util
10
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 1 Wiki Activity

Fix Decimal can be constructed with a negative atomics

Browse Source
This commit is contained in:
Tien Nguyen Khac 2022-06-22 12:05:34 +12:00
parent 05f89b107b
commit 6f22e00488
2 changed files with 11 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
packages/math/src/decimal.spec.ts
View File

@ -31,6 +31,10 @@ describe("Decimal", () => {
expect(Decimal.fromAtomics("44", 3).toString()).toEqual("0.044");
expect(Decimal.fromAtomics("44", 4).toString()).toEqual("0.0044");
});
it("throws for atomics that are not non-negative", () => {
expect(() => Decimal.fromAtomics("-1", 0)).toThrowError(/atomics must not be negative/i);
});
});
describe("fromUserInput", () => {

8
packages/math/src/decimal.ts
View File

@ -107,8 +107,14 @@ export class Decimal {
};
private constructor(atomics: string, fractionalDigits: number) {
const _atomics = new BN(atomics);
if (_atomics.isNeg()) {
throw new Error("Atomics must not be negative");
}
this.data = {
atomics: new BN(atomics),
atomics: _atomics,
fractionalDigits: fractionalDigits,
};
}