From e3ce6eb3d8f3921710d74d1d7d54f183f390c801 Mon Sep 17 00:00:00 2001 From: Simon Warta Date: Tue, 23 Nov 2021 10:16:10 +0100 Subject: [PATCH 1/2] Add missing BlockSearchResponse case to Response --- CHANGELOG.md | 4 ++++ packages/tendermint-rpc/src/tendermint34/responses.ts | 1 + 2 files changed, 5 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 20b59cf2..d20828e4 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -6,6 +6,10 @@ and this project adheres to ## [Unreleased] +### Fixed + +- @cosmjs/tendermint-rpc: Add missing `BlockSearchResponse` case to `Response`. + ### Changed - @cosmjs/stargate: Remove verified queries from `AuthExtension` and diff --git a/packages/tendermint-rpc/src/tendermint34/responses.ts b/packages/tendermint-rpc/src/tendermint34/responses.ts index 926178a6..dfbc4e9a 100644 --- a/packages/tendermint-rpc/src/tendermint34/responses.ts +++ b/packages/tendermint-rpc/src/tendermint34/responses.ts @@ -8,6 +8,7 @@ export type Response = | AbciQueryResponse | BlockResponse | BlockResultsResponse + | BlockSearchResponse | BlockchainResponse | BroadcastTxAsyncResponse | BroadcastTxSyncResponse From 90ebdd2bc432a78af51fabf83060c2090e4793ee Mon Sep 17 00:00:00 2001 From: Simon Warta Date: Tue, 23 Nov 2021 10:21:32 +0100 Subject: [PATCH 2/2] Add hash to BroadcastTxAsyncResponse --- CHANGELOG.md | 7 +++++++ packages/tendermint-rpc/src/tendermint34/responses.ts | 8 ++++++-- .../src/tendermint34/tendermint34client.spec.ts | 3 +-- 3 files changed, 14 insertions(+), 4 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index d20828e4..de59d356 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -6,6 +6,13 @@ and this project adheres to ## [Unreleased] +### Added + +- @cosmjs/tendermint-rpc: Add `hash` field to `BroadcastTxAsyncResponse` + ([#938]). + +[#938]: https://github.com/cosmos/cosmjs/issues/938 + ### Fixed - @cosmjs/tendermint-rpc: Add missing `BlockSearchResponse` case to `Response`. diff --git a/packages/tendermint-rpc/src/tendermint34/responses.ts b/packages/tendermint-rpc/src/tendermint34/responses.ts index dfbc4e9a..14066f23 100644 --- a/packages/tendermint-rpc/src/tendermint34/responses.ts +++ b/packages/tendermint-rpc/src/tendermint34/responses.ts @@ -71,8 +71,12 @@ export interface BlockchainResponse { readonly blockMetas: readonly BlockMeta[]; } -/** No data in here because RPC method BroadcastTxAsync "returns right away, with no response" */ -export interface BroadcastTxAsyncResponse {} +/** + * No transaction data in here because RPC method BroadcastTxAsync "returns right away, with no response" + */ +export interface BroadcastTxAsyncResponse { + readonly hash: Uint8Array; +} export interface BroadcastTxSyncResponse extends TxData { readonly hash: Uint8Array; diff --git a/packages/tendermint-rpc/src/tendermint34/tendermint34client.spec.ts b/packages/tendermint-rpc/src/tendermint34/tendermint34client.spec.ts index 584f7c00..ed1a3638 100644 --- a/packages/tendermint-rpc/src/tendermint34/tendermint34client.spec.ts +++ b/packages/tendermint-rpc/src/tendermint34/tendermint34client.spec.ts @@ -90,8 +90,7 @@ function defaultTestSuite(rpcFactory: () => RpcClient, expected: ExpectedValues) const tx = buildKvTx(randomString(), randomString()); const response = await client.broadcastTxAsync({ tx: tx }); - // TODO: Remove any cast after https://github.com/cosmos/cosmjs/issues/938 - expect((response as any).hash.length).toEqual(32); + expect(response.hash.length).toEqual(32); client.disconnect(); });