From 42369eba124c75f85762ae9d7b87ca26abd3b0d5 Mon Sep 17 00:00:00 2001
From: Simon Warta <simon@warta.it>
Date: Tue, 11 Feb 2020 23:56:14 +0100
Subject: [PATCH] Cleanup unused encodePubkey

---
 packages/bcp/src/encode.spec.ts | 4 ++--
 packages/bcp/src/encode.ts      | 8 +++-----
 2 files changed, 5 insertions(+), 7 deletions(-)

diff --git a/packages/bcp/src/encode.spec.ts b/packages/bcp/src/encode.spec.ts
index 26aac966..5c63bfe9 100644
--- a/packages/bcp/src/encode.spec.ts
+++ b/packages/bcp/src/encode.spec.ts
@@ -67,8 +67,8 @@ describe("encode", () => {
     },
   ];
 
-  describe("encodePubKey", () => {
-    it("encodes a Secp256k1 pubkey", () => {
+  describe("encodePubkey", () => {
+    it("works for compressed public key", () => {
       expect(encodePubkey(defaultPubkey)).toEqual({
         type: "tendermint/PubKeySecp256k1",
         value: "AtQaCqFnshaZQp6rIkvAPyzThvCvXSDO+9AzbxVErqJP",
diff --git a/packages/bcp/src/encode.ts b/packages/bcp/src/encode.ts
index 64f18cdb..49056033 100644
--- a/packages/bcp/src/encode.ts
+++ b/packages/bcp/src/encode.ts
@@ -1,5 +1,5 @@
 /* eslint-disable @typescript-eslint/camelcase */
-import { encodeSecp256k1Signature, types } from "@cosmwasm/sdk";
+import { encodeSecp256k1Pubkey, encodeSecp256k1Signature, types } from "@cosmwasm/sdk";
 import {
   Algorithm,
   Amount,
@@ -17,13 +17,11 @@ import { BankTokens, Erc20Token } from "./types";
 
 const { toBase64 } = Encoding;
 
+// TODO: This function seems to be unused and is not well tested (e.g. uncompressed secp256k1 or ed25519)
 export function encodePubkey(pubkey: PubkeyBundle): types.PubKey {
   switch (pubkey.algo) {
     case Algorithm.Secp256k1:
-      return {
-        type: types.pubkeyType.secp256k1,
-        value: toBase64(pubkey.data),
-      };
+      return encodeSecp256k1Pubkey(pubkey.data);
     case Algorithm.Ed25519:
       return {
         type: types.pubkeyType.ed25519,