From 7b426a3aea9a690861e8e87d9220b3344360cede Mon Sep 17 00:00:00 2001
From: David Terpay <35130517+davidterpay@users.noreply.github.com>
Date: Tue, 9 May 2023 18:04:10 -0400
Subject: [PATCH] fix(V1): Nil extension fix (#125)

---
 abci/vote_extensions.go      |  2 +-
 abci/vote_extensions_test.go | 12 ++++++------
 2 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/abci/vote_extensions.go b/abci/vote_extensions.go
index 5a0c96e..bed1893 100644
--- a/abci/vote_extensions.go
+++ b/abci/vote_extensions.go
@@ -79,7 +79,7 @@ func (h *VoteExtensionHandler) ExtendVoteHandler() ExtendVoteHandler {
 			}
 		}
 
-		return &ResponseExtendVote{VoteExtension: nil}, nil
+		return &ResponseExtendVote{VoteExtension: []byte{}}, nil
 	}
 }
 
diff --git a/abci/vote_extensions_test.go b/abci/vote_extensions_test.go
index 79f787b..2bd32fd 100644
--- a/abci/vote_extensions_test.go
+++ b/abci/vote_extensions_test.go
@@ -28,21 +28,21 @@ func (suite *ABCITestSuite) TestExtendVoteExtensionHandler() {
 			"empty mempool",
 			func() []byte {
 				suite.createFilledMempool(0, 0, 0, false)
-				return nil
+				return []byte{}
 			},
 		},
 		{
 			"filled mempool with no auction transactions",
 			func() []byte {
 				suite.createFilledMempool(100, 0, 0, false)
-				return nil
+				return []byte{}
 			},
 		},
 		{
 			"mempool with invalid auction transaction (too many bundled transactions)",
 			func() []byte {
 				suite.createFilledMempool(0, 1, int(params.MaxBundleSize)+1, true)
-				return nil
+				return []byte{}
 			},
 		},
 		{
@@ -61,7 +61,7 @@ func (suite *ABCITestSuite) TestExtendVoteExtensionHandler() {
 				suite.Require().NoError(err)
 
 				// this should return nothing since the top bid is not valid
-				return nil
+				return []byte{}
 			},
 		},
 		{
@@ -76,7 +76,7 @@ func (suite *ABCITestSuite) TestExtendVoteExtensionHandler() {
 
 				suite.createFilledMempool(100, 100, 2, true)
 
-				return nil
+				return []byte{}
 			},
 		},
 		{
@@ -95,7 +95,7 @@ func (suite *ABCITestSuite) TestExtendVoteExtensionHandler() {
 				suite.Require().NoError(err)
 
 				// this should return nothing since the top bid is not valid
-				return nil
+				return []byte{}
 			},
 		},
 		{